Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to disable fallback #82

Closed
wants to merge 2 commits into from
Closed

Add option to disable fallback #82

wants to merge 2 commits into from

Conversation

ewolfe
Copy link

@ewolfe ewolfe commented Sep 26, 2019

No description provided.

@sudodoki
Copy link
Owner

Thanks for opening PR!
This might be a reasonable thing to do, I guess. I might name this something like promptFallback or similar because IE specific stuff looks like fallback as well to me. This also would require changes in README.md and typings. @ewolfe do you think you could do that?

shvaikalesh
shvaikalesh reviewed Sep 26, 2019
View reviewed changes
index.js Outdated Show resolved Hide resolved
@ewolfe @shvaikalesh
Refactor conditional logic
69fcde3 
Co-Authored-By: Alexey Shvayka <shvaikalesh@gmail.com>
@ewolfe ewolfe closed this Jan 22, 2020
@ewolfe ewolfe deleted the patch-1 branch January 22, 2020 05:07
@li6834300
Copy link

Is there planning to add this patch in the future? This is a nice to have feature :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shvaikalesh shvaikalesh shvaikalesh left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ewolfe @sudodoki @li6834300 @shvaikalesh